Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added monitoring_config.py #92

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alokgoswami-ag
Copy link
Contributor

fixes #91
Added constant file and moved all constant in constant.py.

@KeerthanaAP
Copy link
Collaborator

@alokgoswami-ag Could you add this constant as well
https://github.com/ocp-power-automation/ci-monitoring-automation/blob/main/monitor.py#L14
But I would suggest a different file name instead of constants.py

@KeerthanaAP
Copy link
Collaborator

@Shilpa-Gokul Could you ptal

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alokgoswami-ag
Once this PR has been reviewed and has the lgtm label, please assign keerthanaap for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

monitor.py Outdated Show resolved Hide resolved
monitor.py Outdated Show resolved Hide resolved
monitor.py Outdated Show resolved Hide resolved
monitor.py Outdated Show resolved Hide resolved
monitoring_config.py Outdated Show resolved Hide resolved
Signed-off-by: alokgoswami-ag <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all the constants to a seperate file
4 participants