config: Adds .nvmrc (#20)

octo-technology · Mar 21, 2024 · 076955e · 076955e
2 parents 9084691 + d98a967
commit 076955e
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 11 deletions.
diff --git a/.github/workflows/build-storybook.yml b/.github/workflows/build-storybook.yml
@@ -26,8 +26,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v4
         with:
-          #         TODO: add version to a .nvmrc or at least a variable
-          node-version: 18.12.1
+          node-version-file: '.nvmrc'
           cache: npm
       - name: Install
         run: npm ci --prefer-offline

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -26,8 +26,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v4
         with:
-          #         TODO: add version to a .nvmrc or at least a variable
-          node-version: 18.12.1
+          node-version-file: '.nvmrc'
           cache: npm
       - name: Install
         run: npm ci --omit=dev --prefer-offline
@@ -36,7 +35,6 @@ jobs:
       - name: Upload artifact
         uses: actions/upload-artifact@v4
         with:
-          # TODO (GAFI 19-03-2024): Add variable for this to avoid using ref when not provided
           name: ${{ env.ARTIFACT_NAME }}
           path: ./dist
           if-no-files-found: error
diff --git a/.github/workflows/publish-package.yml b/.github/workflows/publish-package.yml
@@ -26,8 +26,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v4
         with:
-          #         TODO: add version to a .nvmrc or at least a variable
-          node-version: 18.12.1
+          node-version-file: '.nvmrc'
           cache: npm
           registry-url: 'https://npm.pkg.github.com'
       - name: Install

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -11,8 +11,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v4
         with:
-#         TODO: add version to a .nvmrc or at least a variable
-          node-version: 18.12.1
+          node-version-file: '.nvmrc'
           cache: npm
       - name: Install
         run: npm ci --prefer-offline

diff --git a/.github/workflows/type-check.yml b/.github/workflows/type-check.yml
@@ -11,8 +11,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v4
         with:
-#         TODO: add version to a .nvmrc or at least a variable
-          node-version: 18.12.1
+          node-version-file: '.nvmrc'
           cache: npm
       - name: Install
         run: npm ci --prefer-offline

diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+20.11.1