-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fixup/update build scripts to use newer features from dependencies #246
Conversation
cheerio now can load from URLs directly
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
When trying to run the update script it currently fails with |
All URLs now use the `{varname}` syntax
Resolves #ISSUE_NUMBER
Before the change?
Promise<string>
as of v3got
to fetch the resourcescheerio
After the change?
TypeError
in the update scriptgot
fromURL
function fromcheerio
to load the resources directlycheerio
to v1 stablePull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!