Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fixup/update build scripts to use newer features from dependencies #246

Merged
merged 10 commits into from
Sep 18, 2024

Conversation

wolfy1339
Copy link
Member

Resolves #ISSUE_NUMBER


Before the change?

  • The update script would error out because Prettier returns a Promise<string> as of v3
  • Used got to fetch the resources
  • Used an RC version of cheerio

After the change?

  • Fixes a TypeError in the update script
  • Removes got
  • Use the fromURL function from cheerio to load the resources directly
  • Update cheerio to v1 stable

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member Author

When trying to run the update script it currently fails with Error: Unknown permission: business_permissions_for_

@wolfy1339 wolfy1339 changed the title build: update build scripts to use newer features from dependencies build: fixup/update build scripts to use newer features from dependencies Sep 6, 2024
@wolfy1339 wolfy1339 merged commit c641a40 into main Sep 18, 2024
4 checks passed
@wolfy1339 wolfy1339 deleted the update-deps branch September 18, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants