Skip to content

Commit

Permalink
feat: Updates CheckRun.id to the proper type
Browse files Browse the repository at this point in the history
  • Loading branch information
octokitbot authored Aug 22, 2024
1 parent 590247e commit 791dde4
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
6 changes: 3 additions & 3 deletions src/GitHub/Models/CheckRun.cs
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public class CheckRun : IAdditionalDataHolder, IParsable
public string HtmlUrl { get; set; }
#endif
/// <summary>The id of the check.</summary>
public int? Id { get; set; }
public long? Id { get; set; }
/// <summary>The name of the check.</summary>
#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP3_1_OR_GREATER
#nullable enable
Expand Down Expand Up @@ -152,7 +152,7 @@ public virtual IDictionary<string, Action<IParseNode>> GetFieldDeserializers()
{"external_id", n => { ExternalId = n.GetStringValue(); } },
{"head_sha", n => { HeadSha = n.GetStringValue(); } },
{"html_url", n => { HtmlUrl = n.GetStringValue(); } },
{"id", n => { Id = n.GetIntValue(); } },
{"id", n => { Id = n.GetLongValue(); } },
{"name", n => { Name = n.GetStringValue(); } },
{"node_id", n => { NodeId = n.GetStringValue(); } },
{"output", n => { Output = n.GetObjectValue<CheckRun_output>(CheckRun_output.CreateFromDiscriminatorValue); } },
Expand All @@ -178,7 +178,7 @@ public virtual void Serialize(ISerializationWriter writer)
writer.WriteStringValue("external_id", ExternalId);
writer.WriteStringValue("head_sha", HeadSha);
writer.WriteStringValue("html_url", HtmlUrl);
writer.WriteIntValue("id", Id);
writer.WriteLongValue("id", Id);
writer.WriteStringValue("name", Name);
writer.WriteStringValue("node_id", NodeId);
writer.WriteObjectValue<CheckRun_output>("output", Output);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ public async Task<WithPathGetResponse> GetAsync(Action<RequestConfiguration<With
/// <param name="cancellationToken">Cancellation token to use when cancelling requests</param>
/// <param name="requestConfiguration">Configuration for the request such as headers, query parameters, and middleware options.</param>
/// <exception cref="BasicError">When receiving a 404 status code</exception>
/// <exception cref="BasicError">When receiving a 409 status code</exception>
/// <exception cref="ValidationError">When receiving a 422 status code</exception>
#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP3_1_OR_GREATER
#nullable enable
Expand All @@ -113,7 +112,6 @@ public async Task<FileCommit> PutAsync(WithPathPutRequestBody body, Action<Reque
var errorMapping = new Dictionary<string, ParsableFactory<IParsable>>
{
{"404", BasicError.CreateFromDiscriminatorValue},
{"409", BasicError.CreateFromDiscriminatorValue},
{"422", ValidationError.CreateFromDiscriminatorValue},
};
return await RequestAdapter.SendAsync<FileCommit>(requestInfo, FileCommit.CreateFromDiscriminatorValue, errorMapping, cancellationToken).ConfigureAwait(false);
Expand Down
2 changes: 0 additions & 2 deletions src/GitHub/Repos/Item/Item/Git/Blobs/BlobsRequestBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ public BlobsRequestBuilder(string rawUrl, IRequestAdapter requestAdapter) : base
/// <exception cref="BasicError">When receiving a 403 status code</exception>
/// <exception cref="BasicError">When receiving a 404 status code</exception>
/// <exception cref="BasicError">When receiving a 409 status code</exception>
/// <exception cref="ValidationError">When receiving a 422 status code</exception>
#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP3_1_OR_GREATER
#nullable enable
public async Task<ShortBlob?> PostAsync(BlobsPostRequestBody body, Action<RequestConfiguration<DefaultQueryParameters>>? requestConfiguration = default, CancellationToken cancellationToken = default)
Expand All @@ -71,7 +70,6 @@ public async Task<ShortBlob> PostAsync(BlobsPostRequestBody body, Action<Request
{"403", BasicError.CreateFromDiscriminatorValue},
{"404", BasicError.CreateFromDiscriminatorValue},
{"409", BasicError.CreateFromDiscriminatorValue},
{"422", ValidationError.CreateFromDiscriminatorValue},
};
return await RequestAdapter.SendAsync<ShortBlob>(requestInfo, ShortBlob.CreateFromDiscriminatorValue, errorMapping, cancellationToken).ConfigureAwait(false);
}
Expand Down
2 changes: 1 addition & 1 deletion src/GitHub/kiota-lock.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"descriptionHash": "2A275CA0C1BC6884322B17DC1FC9558B61329DE5207AAB92506C0235D5002569BC7341E821733BED96F5763A9D461DB59AB267A12789BFB78632EAAA6AC0F41C",
"descriptionHash": "0D3690030724DAFB97ECAD0A8982B6CBBCFE42B8BF2CF9DA0449ECC00DA8023FEFDDFBB879E522524DF56BB1B0BF645EFF8DAD87CC280FE60AEFA061FC071C23",
"descriptionLocation": "../../../../../schemas/api.github.com.json",
"lockFileVersion": "1.0.0",
"kiotaVersion": "1.14.0",
Expand Down

0 comments on commit 791dde4

Please sign in to comment.