Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): fix test workflow to assure it is not skipped if test_matrix fails #735

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Sep 1, 2022

Description

  • Add always() condition to assure the workflow is not skipped if test_matrix fails
  • Add logic to make the actual job fail if one of the tests of 'test_matrix' failed

Context

octokit/auth-oauth-device.js#74


🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾

@oscard0m oscard0m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 1, 2022
@wolfy1339 wolfy1339 merged commit 852f968 into master Sep 1, 2022
@wolfy1339 wolfy1339 deleted the fix-test-workflow branch September 1, 2022 21:09
@github-actions
Copy link
Contributor

🎉 This PR is included in version 11.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

🎉 This PR is included in version 10.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants