-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ux logo on mobile #11
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rsdeus seeing the code you change, I think this is not a bug, but a feature.
Did you check if in the admin side it is possible to upload a mobile logo?
As there is a class that hide on desktop and the otherone one mobile, that's a common pattern to use 2 different image.
No, there is no field for mobile logo, only "icon", "logo" and "logo footer". |
} | ||
|
||
&__logo-mobile { | ||
@apply lg:hidden; | ||
@apply hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, it's always hidden, it make no sense to have this class, and should be removed as well in the html view.
🎩 What? Why?
The logo disappears when window width is less than 1024px.
📌 Related Issues
https://git.octree.ch/decidim/decidim-nightly/-/issues/68#note_47066
📷 Screenshots