Fix prevent js crashes from null value in messages #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
froger
requested changes
Nov 21, 2024
| @@ -25,9 +25,11 @@ export const getMessages = (key = null) => { | |||
| * @returns {Object} The converted dictionary object | |||
| */ | |||
| export const createDictionary = (messages, prefix = "") => { | |||
| if (!messages) return {}; | |||
There was a problem hiding this comment.
Suggested change
| if (!messages) return {}; |
| @@ -25,9 +25,11 @@ export const getMessages = (key = null) => { | |||
| * @returns {Object} The converted dictionary object | |||
| */ | |||
| export const createDictionary = (messages, prefix = "") => { | |||
| if (!messages) return {}; | |||
|
|
|||
| let final = {}; | |||
| Object.keys(messages).forEach((key) => { | |||
There was a problem hiding this comment.
Suggested change
| Object.keys(messages).forEach((key) => { | |
| Object.keys(messages || {}).forEach((key) => { |
rsdeus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When there is a null value in var
messages, thei18n.jsscript crashes, the WYSIWYG editor doesn't show up, and the textarea becomes disabled.📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots