Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html_safe for amendment title to avoid escape from i18n #8

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rsdeus
Copy link
Member

@rsdeus rsdeus commented Nov 26, 2024

🎩 What? Why?

Amendment title escaped because the string is not marked as html safe, showing an encoding problem.

📌 Related Issues

Link your PR to an issue
https://git.octree.ch/decidim/decidim-nightly/-/issues/68#note_46916

Testing

Write, "Création d'un réseau-consigne sur la commune" as the title of an amendment.

📷 Screenshots

image

♥️ Thank you!

@rsdeus rsdeus requested a review from froger November 26, 2024 09:18
@rsdeus rsdeus self-assigned this Nov 26, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@froger
Copy link
Member

froger commented Nov 26, 2024

Thanks @rsdeus all good for me. Just check the PR title, linters are not happy.
I guess test might be required, not sure you have the bandwith to submit to decidim repo and then answer request in a timely manner.

Maybe we shoud keep this one open, and propose all the MUST HAVE together when they are done?
What do you think?

@rsdeus rsdeus changed the title html_safe for amendment title to avoid escape from i18n fix: html_safe for amendment title to avoid escape from i18n Nov 26, 2024
@rsdeus rsdeus changed the title fix: html_safe for amendment title to avoid escape from i18n Fix html_safe for amendment title to avoid escape from i18n Nov 26, 2024
@rsdeus
Copy link
Member Author

rsdeus commented Nov 27, 2024

Thanks @rsdeus all good for me. Just check the PR title, linters are not happy. I guess test might be required, not sure you have the bandwith to submit to decidim repo and then answer request in a timely manner.

Maybe we shoud keep this one open, and propose all the MUST HAVE together when they are done? What do you think?

@rsdeus rsdeus closed this Nov 27, 2024
@rsdeus rsdeus reopened this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants