Propagate master only when analysis changes #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes this is a much better fix! Thanks :) |
kit-ty-kate
commented
Jan 30, 2023
Comment on lines
+339
to
+340
| and> meta = Current.Analysis.metadata x in | ||
| Result.iter (fun x -> prev := Ok x, meta) x; |
There was a problem hiding this comment.
There seem to be some issues here. The metadata and the state aren't in sync which can cause problem:
Here is the log (and previous working logs): https://opam-repo-ci.ci3.ocamllabs.io/job/2023-01-30/183948-opam-ci-analyse-9093d6
kit-ty-kate
commented
Jan 31, 2023
service/pipeline.ml
Outdated
| Analyse.examine ~master src | ||
| |> Current.cutoff (* keep the old master if the analysis hasn't changed *) | ||
| ~eq:(fun (_, old_analysis) (_, new_analysis) -> | ||
| Analyse.Analysis.equal old_analysis new_analysis) |
There was a problem hiding this comment.
I think I'm seeing something rather annoying with this change.
The old behaviour is:
- if a PR fails with something unrelated
- and we open and merge a new PR to fix those unrelated issues
- we expect the new master commit to be used when clicking the rebuild button on the first PR
However with this change it seems that the old master commit remain and thus the change isn't taken into account.
kit-ty-kate
force-pushed
the
stop-recreate-graph-on-analysis-build
branch
from
5575d4c to
9854379
Compare
kit-ty-kate
force-pushed
the
stop-recreate-graph-on-analysis-build
branch
from
9854379 to
1513f43
Compare
|
Tested successfully (so far) live |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #204 cc @art-w
We just have to wait for ocurrent/ocurrent#330 to be merged and this is good to go.
Already being tested in production.