Skip deleted packages in analysis #402
Conversation
There was a problem hiding this comment.
I think this fix makes good sense! Thank you for helping ensure the archiving effort can proceed smoothly.
Do you think you'd be able to a test for this cas without too much trouble?
However, outside of the archiving process, I think we do not ever want packages deleted, so I wonder if we should make an issue to add some logic to the linting that would raise a warning for deleted packages? WDYT?
Currently, the analysis phase doesn't expect any package deletions and fails with the error "impossible". But, with the new opam-repository archival process, some packages are expected to be deleted from the main opam-repository and moved into the archive repository.
Yes, that makes sense. We could also try to detect the archiving process using PR author GitHub handles and restrict deletions only to the opam-repository maintainers. But, even a more light-weight check would be useful. |
punchagan
force-pushed
the
skip-deleted-analysis
branch
from
64494c8 to
9ff251b
Compare
Previously, the analysis phase didn't expect any package deletions. So, we'd fail with the error "impossible". But, with the new opam-repository archival process, we allow for deletions, even though only in the special case of a package being archived.
punchagan
force-pushed
the
skip-deleted-analysis
branch
from
9ff251b to
906d7d7
Compare
I've added a cram test for this case. |
Potential fix for comment here.