-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
111 running long tasks on mmoda #121
Conversation
Looks ok to me! oda_api still needs to be updated of course. |
@okolo , I vaguely agree with comments of @dsavchenko . Please see to consider them and respond. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line with the points raised by @dsavchenko
…enamed to _pass_callback_url
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 20.46% 21.35% +0.89%
==========================================
Files 31 32 +1
Lines 2693 2725 +32
==========================================
+ Hits 551 582 +31
- Misses 2142 2143 +1 ☔ View full report in Codecov by Sentry. |
I would like to approve, but the CI action fails. |
I suppose there was a reason. Can you try to release the constrain, @okolo ? |
passing callback to oda_api through .oda_api_callback file was implemented