Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

111 running long tasks on mmoda #121

Merged
merged 14 commits into from
Jan 10, 2024
Merged

Conversation

okolo
Copy link
Contributor

@okolo okolo commented Nov 7, 2023

passing callback to oda_api through .oda_api_callback file was implemented

@okolo okolo linked an issue Nov 7, 2023 that may be closed by this pull request
@volodymyrss
Copy link
Member

Looks ok to me! oda_api still needs to be updated of course.

@volodymyrss
Copy link
Member

@okolo , I vaguely agree with comments of @dsavchenko . Please see to consider them and respond.

Copy link
Contributor

@burnout87 burnout87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line with the points raised by @dsavchenko

tests/test_callback.py Show resolved Hide resolved
nb2workflow/nbadapter.py Outdated Show resolved Hide resolved
nb2workflow/nbadapter.py Outdated Show resolved Hide resolved
nb2workflow/nbadapter.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (33de39b) 20.46% compared to head (9820e15) 21.35%.

❗ Current head 9820e15 differs from pull request most recent head ad7ad7a. Consider uploading reports for the commit ad7ad7a to get more accurate results

Files Patch % Lines
nb2workflow/nbadapter.py 0.00% 11 Missing ⚠️
nb2workflow/service.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   20.46%   21.35%   +0.89%     
==========================================
  Files          31       32       +1     
  Lines        2693     2725      +32     
==========================================
+ Hits          551      582      +31     
- Misses       2142     2143       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@volodymyrss volodymyrss requested a review from burnout87 December 6, 2023 13:41
@dsavchenko
Copy link
Member

I would like to approve, but the CI action fails.
There is a problem installing owlready2 there. Its version is fixed to a really old one in requirements. @volodymyrss was there a particular reason for this?

@volodymyrss
Copy link
Member

I would like to approve, but the CI action fails. There is a problem installing owlready2 there. Its version is fixed to a really old one in requirements. @volodymyrss was there a particular reason for this?

I suppose there was a reason. Can you try to release the constrain, @okolo ?

@volodymyrss volodymyrss merged commit 2d54b5b into master Jan 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running long tasks on MMODA
5 participants