Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return jobdir for started async jobs #131

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Conversation

dsavchenko
Copy link
Member

No description provided.

@dsavchenko dsavchenko linked an issue Dec 19, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (a9ba65c) 20.43% compared to head (650d155) 20.46%.
Report is 6 commits behind head on master.

Files Patch % Lines
nb2workflow/nbadapter.py 0.00% 11 Missing ⚠️
nb2workflow/service.py 0.00% 11 Missing ⚠️
nb2workflow/deploy.py 0.00% 1 Missing ⚠️
nb2workflow/workflows.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   20.43%   20.46%   +0.02%     
==========================================
  Files          31       31              
  Lines        2682     2693      +11     
==========================================
+ Hits          548      551       +3     
- Misses       2134     2142       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@volodymyrss volodymyrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it can be refactored to create tmp directory differently, using the key, but for now it's ok, thanks!

@volodymyrss volodymyrss merged commit 736d95b into master Dec 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return jobdir while job is still not done
3 participants