Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy to k8s: set container name in new deployment, don't attempt to create service if exist #140

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

dsavchenko
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (2d5d9c1) 21.70% compared to head (6d87c55) 21.49%.
Report is 6 commits behind head on master.

Files Patch % Lines
tests/test_nbadapter.py 11.76% 15 Missing ⚠️
nb2workflow/nbadapter.py 0.00% 11 Missing ⚠️
tests/conftest.py 22.22% 7 Missing ⚠️
nb2workflow/deploy.py 0.00% 5 Missing ⚠️
nb2workflow/service.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   21.70%   21.49%   -0.21%     
==========================================
  Files          32       32              
  Lines        2746     2782      +36     
==========================================
+ Hits          596      598       +2     
- Misses       2150     2184      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsavchenko
Copy link
Member Author

Also, adapted to current oda_api (send callback function)

@dsavchenko dsavchenko marked this pull request as ready for review February 15, 2024 10:57
@volodymyrss
Copy link
Member

volodymyrss commented Feb 15, 2024

could you please change the PR name into something descriptive?

@dsavchenko dsavchenko changed the title fix deployment Fix deploy to k8s: set container name in new deployment, don't attempt to create service if exist Feb 15, 2024
@volodymyrss volodymyrss merged commit 8f197a8 into master Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants