Remove implicit anchors, as they are not yet supported in the spec #272
Conversation
✅ Deploy Preview for anchor-position-wpt canceled.
|
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
I'm approving because this is better than no note, but my leaning would be to remove support for the anchor attribute if it looks like it won't eventually land. I don't want to encourage people to use features that have a low percent chance of being implemented natively. @mirisuzanne What do you think?
|
@jamesnw Related to this, it looks like the spec has removed |
I agree with @jgerigmeyer |
jamesnw
changed the title
* main: Update links and add description to readme. Adjust examples Fix tests remove reference to open-props lint lint spacing apply OddBird brand tokens to demo site
| // Store anchor name | ||
| anchorName = name.name; | ||
| } | ||
| if (isIdentifier(name) && name.name.startsWith('--')) { |
There was a problem hiding this comment.
I was hesitant to combine these ifs, as it subtly changes the logic, but it ends up not making a difference, so it makes sense to combine.
The
anchorattribute has been removed from the standard pending conversation here- whatwg/html#9144. Alternatively, we could remove this feature until it is supported, but I'm not sure it's worth it.