Replace shallow options merge with deep

oddcamp · Jun 8, 2020 · e03d618 · e03d618
1 parent dd58b12
commit e03d618
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -17,7 +17,6 @@ const tu = new TrackingUtil({
   services: {
     gtm: {
       id: `GTM-XXXX`,
-      dataLayerName: `dataLayer`,
     },
   },
 })

diff --git a/example/index.js b/example/index.js
@@ -4,7 +4,6 @@ const tu = new TrackingUtil({
   services: {
     gtm: {
       id: `GTM-XXXX`,
-      dataLayerName: `dataLayer`,
     },
   },
 })

diff --git a/index.js b/index.js
@@ -1,4 +1,5 @@
 import Cookies from "universal-cookie"
+import merge from "lodash/merge"
 
 class TrackingUtil {
   constructor(options = {}) {
@@ -11,7 +12,7 @@ class TrackingUtil {
     if (window.trackingUtil) return null
 
     // Default options
-    const defaultOptions = {
+    this.options = {
       cookie: {
         name: `tracking-util-reacted`,
         options: {
@@ -28,10 +29,7 @@ class TrackingUtil {
       },
     }
 
-    this.options = {
-      ...defaultOptions,
-      ...options,
-    }
+    merge(this.options, options)
 
     this.status = {
       userReacted: false,

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@kollegorna/tracking-util",
-  "description": "A helper for tracking GTM and GA in a GDPR way",
-  "version": "1.0.1",
+  "description": "GDPR compliant tracking",
+  "version": "1.0.2",
   "author": "Kollegorna <[email protected]>",
   "license": "MIT",
   "private": false,
@@ -11,6 +11,7 @@
     "build": "parcel build example/index.html"
   },
   "dependencies": {
+    "lodash": "^4.17.15",
     "universal-cookie": "^4.0.3"
   },
   "devDependencies": {
-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ const tu = new TrackingUtil({ @@
       services: {
         gtm: {
           id: `GTM-XXXX`,
-          dataLayerName: `dataLayer`,
         },
       },
     })
@@ Expand Down @@