-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all keyboard handling functionality #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this, but firstly we have to understand the implications of removing this feature and what things could be affected if we do so. Here's a non-exhaustive list of what's imediately obvious, feel free to correct it or add things to it as you see fit
- web browsing functionality: because we can't use browse mode and since quick navigation is required on today's internet, we basically can't use anything that can't be efficiently be used with focus mode, so the only thing we could use is a web app which is well suited to focus mode only browsing, aka google docks, visual studio code, etc
- caret navigation will be mostly broken, mostly on the web again: remember what I said a long time ago about how orca does caret changed events? well, firefox is so based around this mechanism that we don't even get caret changed events when moving through the lines of a paragraph, so we either have to rely on orca's mechanism which will be impossible to do now we don't have key handling anymore, or find a way for firefox to emit those events in all cases.
- in the future, we might lose stuff like object navigation and other things of that nature, but hopefully the problem will be solved till then.
So yeah, I do agree with you when it comes to delivering half-baked features, however at the same time, our 0.1.0 would be crippled in features way beyond what we actually have in the codebase prepaired for 0.1.0 itself. If you are ok with the previous list being true, at least temporarily, then go ahead, I'll merge. Be warned though, CI is failing, you have to fix that before I'll allow the merge.
I don't know where you heard this, but this is false. I'm able to receive all the events regardless of if I have keybindings activatednor not. The issue is that caret navigation is not implemented—this is a basic feature that absolutely does need to be omplemented before 0.1.0
Again, no idea where you got this idea, but atspi events should be received regardless of wether we have a key handler or not. |
@TTWNO |
@albertotirla , again, this is false. It absolutely does sent text caret moved evenrs within the same accessible. |
Our current implementation of keyboard handling is a hack, and this was known from the start. I think it's time we remove it.
This branch changes the name of a few input sockets, as well as completely removes all functionality related to keyboard handling.
I think for a first release, and absolute beta, we can get away without keyboard handling. Keyboard and tab navigation should work without the keyboard deamon.
If we're going to implement keyboard handling, let's do it right and not ship a half-baked feature.