Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coding: Search Instances in Survey #154

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

khushishikhu
Copy link

@khushishikhu khushishikhu commented Apr 3, 2021

FIXED ISSUE odk-x/tool-suite-X#225

Description

Added the Search instances in the forms of ODK-X Survey according to the ODK-X Tables by making changes in the relevant files.

Additional context

Currently I tried to write code to search the instances by their name, but it doesn't work and I am unable to figure it out what is missing. Please review my this PR and help me from should I take any hint/reference to make it work

@wbrunette wbrunette requested a review from linl33 April 3, 2021 18:38
@linl33 linl33 changed the base branch from master to development April 4, 2021 03:14
@linl33
Copy link
Member

linl33 commented Apr 4, 2021

@khmermenten Please see my comment on the issue odk-x/tool-suite-X#225 (comment)

@khushishikhu
Copy link
Author

khushishikhu commented Apr 8, 2021

@linl33 can you please help how can I test this code changes, because when I changed this file it stops working properly (especially in js file) on my localhost as it was before I made any changes. As I have done some changes again after you reviewed this PR

@khushishikhu
Copy link
Author

I have researched a lot and according to that made some changes in controller.js too, also continuously tracking in the console but it is still not searching can you please help me to know how can I made changes in the code or can read any documentation so that the search function works properly. That would really be a great help. Thank you!!

@wbrunette
Copy link
Member

@linl33 or @clarlars any guidance?

@khushishikhu
Copy link
Author

@wbrunette @elmps2018 @linl33 I have tried to write the function on a javascript file and constantly track what is going on in console. But unable to make the instance display on the screen for what is being searched. Please can you provide me any reference of what I should look for to make the function that runs perfectly.

@khushishikhu
Copy link
Author

khushishikhu commented Apr 17, 2021

@elmps2018 Can I take other issues along with this because it's taking time for me to solve this as until now this seems quite difficult to me in finding the way for solving this issue after a lot of research and trying.

@wbrunette
Copy link
Member

@khushishikhu you can take on another issue because like I said before we were counting the two related issues as one.

With regards to approach:

  1. Are you developing using app-designer? This makes it easier because you can you can see the console and put breakpoints in (allowing you to step through code). Check out: https://developer.chrome.com/docs/devtools/console/
  2. When I am trying to do something and I can't find the problem, I use console.error() for my log statements as you can filter out other console.log and console.warn (the console logs being shown can be changed by the serverity of the log can be changed in the devtools console). NOTE: you do not want to check them in as error messages but can help track what what is going on by making your log statements stand out as errors.
  3. I add a word in my log statement that is unique and not likely to used in other log statements so it's easy to use the search bar in the devtools console.

@khushishikhu
Copy link
Author

khushishikhu commented Apr 17, 2021

@wbrunette just like you have said for console.log() and console (which is really helpful and I have understood the information you have given) but here in this repository app-designer I have come across odkCommon.log() term. Can you please explain to me what this term signifies in prompt.js file and what is the difference in between these two

@wbrunette
Copy link
Member

When on the android device we also want to write out to a file so it can be reviewed later if problems happen. There are log files written out inside the output folder. See https://docs.odk-x.org/config-file-structure/

Similar to what i said above you can put temporary logs in that work well for you, but please remove them before submitting a pull request.

@wbrunette wbrunette requested review from wbrunette and clarlars April 28, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants