style: Support correctly :first-child, :last-child, and > *.

src/vaev-driver/res/user-agent.css

@@ -215,4 +215,5 @@ tr {
 td,
 th {
     display: table-cell;
+    font-weight: bold;
 }

src/vaev-style/select.cpp

@@ -176,6 +176,37 @@ static bool _matchLink(Markup::Element const &el) {
     return el.tagName == Html::A and el.hasAttribute(Html::HREF_ATTR);
 }
 
+// 14.3.3. :first-child pseudo-class
+// https://www.w3.org/TR/selectors-4/#the-first-child-pseudo
+
+static bool _matchFirstChild(Markup::Element const &e) {
+    Cursor<Markup::Node> curr = &e;
+    while (curr->hasPreviousSibling()) {
+        auto prev = curr->previousSibling();
+        if (auto el = prev.is<Markup::Element>())
+            return false;
+        curr = &prev.unwrap();
+    }
+    return true;
+}
+
+// 14.3.4. :last-child pseudo-class
+// https://www.w3.org/TR/selectors-4/#the-last-child-pseudo
+
+static bool _matchLastChild(Markup::Element const &e) {
+    //    yap("coucouuuuuu {}", e);
+    Cursor<Markup::Node> curr = &e;
+    while (curr->hasNextSibling()) {
+        auto next = curr->nextSibling();
+        //        yap("next: {}", next);
+        if (auto el = next.is<Markup::Element>())
+            return false;
+        curr = &next.unwrap();
+    }
+    //    yap("bruh");
+    return true;
+}
+
 // 14.4.3. :first-of-type pseudo-class
 // https://www.w3.org/TR/selectors-4/#the-first-of-type-pseudo
 
@@ -225,6 +256,12 @@ static bool _match(Pseudo const &s, Markup::Element const &el) {
     case Pseudo::LAST_OF_TYPE:
         return _matchLastOfType(el);
 
+    case Pseudo::FIRST_CHILD:
+        return _matchFirstChild(el);
+
+    case Pseudo::LAST_CHILD:
+        return _matchLastChild(el);
+
     default:
         logDebugIf(DEBUG_SELECTORS, "unimplemented pseudo class: {}", s);
         return false;
@@ -355,7 +392,8 @@ static OpCode _peekOpCode(Cursor<Css::Sst> &cur) {
             cur.peek() == Css::Token::IDENT or
             cur.peek() == Css::Token::HASH or
             cur.peek().token.data == "." or
-            cur.peek().token.data == "*"
+            cur.peek().token.data == "*" or
+            cur.peek().token.data == ":"
         ) {
             return OpCode::DESCENDANT;
         } else {
@@ -409,7 +447,7 @@ static Selector _parseInfixExpr(Selector lhs, Cursor<Css::Sst> &cur, OpCode opCo
 
 static Selector _parseSelectorElement(Cursor<Css::Sst> &cur, OpCode currentOp) {
     if (cur.ended()) {
-        // logError("ERROR : unterminated selector");
+        logErrorIf(DEBUG_SELECTORS, "ERROR : unterminated selector");
         return EmptySelector{};
     }
     Selector val;
@@ -438,11 +476,17 @@ static Selector _parseSelectorElement(Cursor<Css::Sst> &cur, OpCode currentOp) {
             if (cur->token.type == Css::Token::COLON) {
                 cur.next();
                 if (cur.ended()) {
-                    // logError("ERROR : unterminated selector");
+                    logErrorIf(DEBUG_SELECTORS, "ERROR : unterminated selector");
                     return EmptySelector{};
                 }
             }
-            val = Pseudo::make(cur->token.data);
+
+            if (cur->prefix == Css::Token::function("not(")) {
+                Cursor<Css::Sst> c = cur->content;
+                val = Selector::not_(_parseSelectorElement(c, OpCode::NOT));
+            } else {
+                val = Pseudo::make(cur->token.data);
+            }
             break;
         default:
             val = ClassSelector{cur->token.data};
@@ -551,6 +595,7 @@ Selector Selector::parse(Cursor<Css::Sst> &c) {
         return EmptySelector{};
     }
 
+    logDebugIf(DEBUG_SELECTORS, "PARSING SELECTOR : {}", c);
     Selector currentSelector = _parseSelectorElement(c, OpCode::NOP);
 
     while (not c.ended()) {

src/vaev-style/tests/test-parse-selectors.cpp

@@ -117,6 +117,11 @@ test$("vaev-style-parse-infix-selectors") {
         )
     );
 
+    expectEq$(
+        Selector::parse(":not(.className)"),
+        Selector::not_(ClassSelector{"className"s})
+    );
+
     return Ok();
 }
 
@@ -167,6 +172,40 @@ test$("vaev-style-parse-mixed-selectors") {
         )
     );
 
+    expectEq$(
+        Selector::parse(":not(:first-child)"),
+        Selector::not_(Pseudo{Pseudo::FIRST_CHILD})
+    );
+
+    expectEq$(
+        Selector::parse("tr:not(:last-child) th:not(:first-child)"),
+        Selector::descendant(
+            Selector::and_({TypeSelector{Html::TR}, Selector::not_(Pseudo{Pseudo::LAST_CHILD})}),
+            Selector::and_({TypeSelector{Html::TH}, {Selector::not_(Pseudo{Pseudo::FIRST_CHILD})}})
+        )
+    );
+
+    expectEq$(
+        Selector::parse(".o_content .o_table > thead > tr:not(:last-child) th:not(:first-child)"),
+        Selector::descendant(
+            Selector::child(
+                Selector::descendant(
+                    ClassSelector{"o_content"s},
+                    Selector::child(ClassSelector{"o_table"s}, TypeSelector{Html::THEAD})
+                ),
+                Selector::and_({TypeSelector{Html::TR}, Selector::not_(Pseudo{Pseudo::LAST_CHILD})})
+            ),
+            Selector::and_({TypeSelector{Html::TH}, {Selector::not_(Pseudo{Pseudo::FIRST_CHILD})}})
+        )
+    );
+
+    expectEq$(
+        Selector::parse(".o_content .o_table thead, .o_content .o_table tbody, .o_content .o_table tfoot, .o_content .o_table tr, .o_content .o_table td, .o_content .o_table th "),
+        Selector::descendant(
+            Selector::and_({TypeSelector{Html::TR}, Selector::not_(Pseudo{Pseudo::LAST_CHILD})}),
+            Selector::and_({TypeSelector{Html::TH}, {Selector::not_(Pseudo{Pseudo::FIRST_CHILD})}})
+        )
+    );
     return Ok();
 }
 
@@ -186,6 +225,24 @@ test$("vaev-style-parse-pseudo-selectors") {
         Pseudo{Pseudo::make("root")}
     );
 
+    expectEq$(
+        Selector::parse(":first-child"),
+        Pseudo{Pseudo::FIRST_CHILD}
+    );
+
+    expectEq$(
+        Selector::parse(":last-child"),
+        Pseudo{Pseudo::LAST_CHILD}
+    );
+
+    expectEq$(
+        Selector::parse(".class :last-child"),
+        Selector::descendant(
+            ClassSelector{"class"s},
+            Pseudo{Pseudo::LAST_CHILD}
+        )
+    );
+
     expectEq$(
         Selector::parse("html:hover"),
         Selector::and_({