impl-posix: Fixup backtrace printing on panic.

odoo · Dec 11, 2024 · f5fab96 · f5fab96
1 parent 61e0c6d
commit f5fab96
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/impls/impl-posix/base.cpp b/src/impls/impl-posix/base.cpp
@@ -21,7 +21,7 @@ Backtrace forceCaptureBacktrace() {
     char **symbols = backtrace_symbols(buffer, count);
 
     for (int i = 0; i < count; i++) {
-        char *symbol = symbols[i];
+        char const *symbol = symbols[i];
         bt._frames.pushBack({
             String(symbol),
             String("unknown"),

diff --git a/src/impls/impl-posix/entry.cpp b/src/impls/impl-posix/entry.cpp
@@ -7,9 +7,9 @@
 void __panicHandler(Karm::PanicKind kind, char const *msg) {
     fprintf(stderr, "%s: %s\n", kind == Karm::PanicKind::PANIC ? "panic" : "debug", msg);
 
-    // NOTE: We hare calling backinto the framework here, it might cause another
+    // NOTE: We are calling backinto the framework here, it might cause another
     //       panic, this is why we are keeping track of nested panics
-    static isize _panicDepth = 1;
+    static isize _panicDepth = 0;
     _panicDepth++;
     if (_panicDepth == 1) {
         auto bt = Karm::Backtrace::capture();