Skip to content

Commit

Permalink
Simplify ttmove reduction
Browse files Browse the repository at this point in the history 
Remove condition that clamps reductions for tt move.

Passed STC:
https://tests.stockfishchess.org/tests/view/66d5f1239de3e7f9b33d14b0
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 91136 W: 23805 L: 23646 D: 43685
Ptnml(0-2): 334, 10328, 24066, 10525, 315

Passed LTC:
https://tests.stockfishchess.org/tests/view/66d7c5889de3e7f9b33d1721
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 139242 W: 35130 L: 35030 D: 69082
Ptnml(0-2): 78, 15200, 38986, 15258, 99

closes #5574

Bench: 1268715
  • Loading branch information
@Vizvezdenec @Disservin
Vizvezdenec authored and Disservin committed Sep 9, 2024
1 parent d7e3a70 commit a8cb002
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/search.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1148,10 +1148,9 @@ Value Search::Worker::search(
if ((ss + 1)->cutoffCnt > 3)
r += 1 + allNode;

// For first picked move (ttMove) reduce reduction, but never allow
// reduction to go below 0 (~3 Elo)
// For first picked move (ttMove) reduce reduction (~3 Elo)
else if (move == ttData.move)
r = std::max(0, r - 2);
r -= 2;

ss->statScore = 2 * thisThread->mainHistory[us][move.from_to()]
+ (*contHist[0])[movedPiece][move.to_sq()]
Expand Down

1 comment on commit a8cb002

@peregrineshahin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

// For first picked move (ttMove) reduce reduction (~3 Elo)
         else if (move == ttData.move)

The first picked move isn't always a ttMove as we all know.. the comment was already wrong before the simplification and removing that part didn't fix obviously.. sometimes it's better to leave stuff uncommented if one is not sure .. radio stations should feel the need to fill the air... not code comment IMO.

Please sign in to comment.