Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Type For Continuation Correction History #5653

Closed
wants to merge 1 commit into from

Conversation

xu-shawn
Copy link
Contributor

@xu-shawn xu-shawn commented Oct 25, 2024

Passed Non-regression STC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 59008 W: 15516 L: 15318 D: 28174
Ptnml(0-2): 207, 6977, 14928, 7195, 197
https://tests.stockfishchess.org/tests/view/6716fbc886d5ee47d953ca6f

Passed Non-regression LTC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 135252 W: 34248 L: 34144 D: 66860
Ptnml(0-2): 102, 14851, 37605, 14977, 91
https://tests.stockfishchess.org/tests/view/6717e6f186d5ee47d953cb58

bench 1238978

bench 1238978
Copy link

clang-format 18 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/noble/clang-format-18.

(execution 11512707605 / attempt 1)

@Disservin Disservin added the simplification A simplification patch label Nov 10, 2024
@Disservin
Copy link
Member

ah sorry forgot to write, i dont really see this as a simplification or anything which should be run with non regression bounds, this basically just changes 1 -> 0

@xu-shawn
Copy link
Contributor Author

xu-shawn commented Nov 13, 2024

Well, I thought its looks better to have const auto for all correction values. 1->0 is just something I thought would be nice to have, but if the maintainer disagrees then so be it.

@Disservin Disservin closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simplification A simplification patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants