forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo PR for DeepTau v2p5 integration #1
Merged
ofivite
merged 23 commits into
CMSSW_12_4_0_pre2_DeepTau_v2p5
from
CMSSW_12_4_0_pre2_DeepTau_v2p5_dev
May 9, 2022
Merged
Demo PR for DeepTau v2p5 integration #1
ofivite
merged 23 commits into
CMSSW_12_4_0_pre2_DeepTau_v2p5
from
CMSSW_12_4_0_pre2_DeepTau_v2p5_dev
May 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandrosov
requested changes
May 4, 2022
kandrosov
requested changes
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptually, all looks good (except the minor comment above). To fish other possible bugs we need to run python vs cmssw validation for both v2p1 and v2p5.
P.S. In case of v2p1 validation is of course old cmssw vs new cmssw code.
kandrosov
approved these changes
May 5, 2022
e087908
to
27cc66f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts
DeepTauId
producer to a new version of v2p5. The changes aren't significant since the architecture hasn't changed much structurally and they include:runTauIdMVA.py
(currently with a preliminary testing version of TF graph)