Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo PR for DeepTau v2p5 integration #1

Merged

Conversation

ofivite
Copy link
Owner

@ofivite ofivite commented May 3, 2022

This PR adapts DeepTauId producer to a new version of v2p5. The changes aren't significant since the architecture hasn't changed much structurally and they include:

@ofivite ofivite requested a review from kandrosov May 3, 2022 13:40
RecoTauTag/RecoTau/interface/DeepTauBase.h Outdated Show resolved Hide resolved
RecoTauTag/RecoTau/interface/DeepTauBase.h Outdated Show resolved Hide resolved
RecoTauTag/RecoTau/interface/DeepTauBase.h Outdated Show resolved Hide resolved
RecoTauTag/RecoTau/plugins/DeepTauId.cc Outdated Show resolved Hide resolved
RecoTauTag/RecoTau/plugins/DeepTauId.cc Outdated Show resolved Hide resolved
RecoTauTag/RecoTau/python/tools/runTauIdMVA.py Outdated Show resolved Hide resolved
@ofivite ofivite requested a review from kandrosov May 4, 2022 17:56
Copy link
Collaborator

@kandrosov kandrosov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually, all looks good (except the minor comment above). To fish other possible bugs we need to run python vs cmssw validation for both v2p1 and v2p5.

P.S. In case of v2p1 validation is of course old cmssw vs new cmssw code.

RecoTauTag/RecoTau/interface/DeepTauBase.h Outdated Show resolved Hide resolved
@ofivite ofivite force-pushed the CMSSW_12_4_0_pre2_DeepTau_v2p5_dev branch from e087908 to 27cc66f Compare May 8, 2022 10:33
@ofivite ofivite merged commit 9c6b458 into CMSSW_12_4_0_pre2_DeepTau_v2p5 May 9, 2022
ofivite pushed a commit that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants