Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for doing all this great work making rangy up-to-date. Would you mind making the "issues" tab available so more people can collaborate on top of the work you started here?
Also, I want to add support for the TextRange module. Would you be willing to take a PR for that once I get things working?
I tried to get this working but ran into a couple problems:
yarn run dev
doesn't work.yarn tsc:es2018
has the following errors:$ tsc -b
``` packages/classapplier/src/index.ts:16:22 - error TS2307: Cannot find module '@rangy/core'.
16 import * as api from "@rangy/core";
~~~~~~~~~~~~~
packages/classapplier/src/index.ts:17:27 - error TS2307: Cannot find module '@rangy/core'.
17 import {dom, Module} from "@rangy/core";
~~~~~~~~~~~~~
packages/selectionsaverestore/src/index.ts:16:22 - error TS2307: Cannot find module '@rangy/core'.
16 import * as api from "@rangy/core";
~~~~~~~~~~~~~
packages/selectionsaverestore/src/index.ts:17:37 - error TS2307: Cannot find module '@rangy/core'.
17 import {Module, dom, features} from "@rangy/core";
~~~~~~~~~~~~~
packages/serializer/src/index.ts:22:22 - error TS2307: Cannot find module '@rangy/core'.
22 import * as api from "@rangy/core";
~~~~~~~~~~~~~
packages/serializer/src/index.ts:23:27 - error TS2307: Cannot find module '@rangy/core'.
23 import {dom, Module} from "@rangy/core";
~~~~~~~~~~~~~
packages/util/src/index.ts:15:22 - error TS2307: Cannot find module '@rangy/core'.
15 import * as api from "@rangy/core";
~~~~~~~~~~~~~
packages/util/src/index.ts:20:8 - error TS2307: Cannot find module '@rangy/core'.
20 } from "@rangy/core";
~~~~~~~~~~~~~
packages/util/src/index.ts:26:14 - error TS2339: Property 'deleteFromDocument' does not exist on type 'WrappedSelection'.
26 this.deleteFromDocument();
~~~~~~~~~~~~~~~~~~
packages/util/src/index.ts:27:26 - error TS2339: Property 'getRangeAt' does not exist on type 'WrappedSelection'.
27 var range = this.getRangeAt(0);
~~~~~~~~~~
packages/util/src/index.ts:30:14 - error TS2339: Property 'setSingleRange' does not exist on type 'WrappedSelection'.
30 this.setSingleRange(range);
~~~~~~~~~~~~~~
packages/util/src/index.ts:34:14 - error TS2339: Property 'deleteFromDocument' does not exist on type 'WrappedSelection'.
34 this.deleteFromDocument();
~~~~~~~~~~~~~~~~~~
packages/util/src/index.ts:35:28 - error TS2339: Property 'getRangeAt' does not exist on type 'WrappedSelection'.
35 const range = this.getRangeAt(0);
~~~~~~~~~~
packages/util/src/index.ts:42:14 - error TS2339: Property 'setSingleRange' does not exist on type 'WrappedSelection'.
42 this.setSingleRange(range);
~~~~~~~~~~~~~~
packages/util/src/index.ts:46:42 - error TS2339: Property 'win' does not exist on type 'WrappedSelection'.
46 var range = api.createRange(this.win);
~~~
packages/util/src/index.ts:48:14 - error TS2339: Property 'setSingleRange' does not exist on type 'WrappedSelection'.
48 this.setSingleRange(range);
~~~~~~~~~~~~~~
packages/util/src/index.ts:54:14 - error TS2339: Property 'deleteContents' does not exist on type 'DomRange'.
54 this.deleteContents();
~~~~~~~~~~~~~~
packages/util/src/index.ts:55:29 - error TS2339: Property 'getDocument' does not exist on type 'DomRange'.
55 var textNode = this.getDocument().createTextNode(text);
~~~~~~~~~~~
packages/util/src/index.ts:56:14 - error TS2339: Property 'insertNode' does not exist on type 'DomRange'.
56 this.insertNode(textNode);
~~~~~~~~~~
packages/util/src/index.ts:60:14 - error TS2339: Property 'deleteContents' does not exist on type 'DomRange'.
60 this.deleteContents();
~~~~~~~~~~~~~~
packages/util/src/index.ts:61:25 - error TS2339: Property 'createContextualFragment' does not exist on type 'DomRange'.
61 var frag = this.createContextualFragment(html);
~~~~~~~~~~~~~~~~~~~~~~~~
packages/util/src/index.ts:62:14 - error TS2339: Property 'insertNode' does not exist on type 'DomRange'.
62 this.insertNode(frag);
~~~~~~~~~~
packages/util/src/index.ts:110:38 - error TS2554: Expected 0 arguments, but got 2.
110 const sel = new WrappedSelection(nativeSel, window)
~~~~~~~~~~~~~~~~~
error TS6053: File '/home/mikob/scratchspace/rangy/packages/test-util/tsconfig.json' not found.