Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing dependency for core package #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding missing dependency for core package #3

wants to merge 1 commit into from

Conversation

heyitaki
Copy link

After npm installing @rangy/highlight, I was running into the following error:

ERROR in ./node_modules/log4javascript/log4javascript.js
Module build failed: Error: ENOENT: no such file or directory, open 'C:\Users\aksha\Documents\tbd2\node_modules\log4javascript\log4javascript.js'
 @ ./node_modules/@rangy/classapplier/lib/esm5/index.js 18:0-49 20:10-34
 @ ./src/components/Content/Sidebar/index.tsx
 @ ./src/components/Content/index.tsx
 @ ./src/app/content.tsx

Although log4javascript is listed as a devDependency in the rangy2 package, it is not listed as a dependency in the @rangy/core package and is therefore throwing the above error.

This PR adds the dependency and resolves the issue. An alternate solution would be to remove use of the logger within the core package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant