Adding missing dependency for core package #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After npm installing @rangy/highlight, I was running into the following error:
Although
log4javascript
is listed as a devDependency in the rangy2 package, it is not listed as a dependency in the @rangy/core package and is therefore throwing the above error.This PR adds the dependency and resolves the issue. An alternate solution would be to remove use of the logger within the core package.