Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slhmy/judge result #49

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Slhmy/judge result #49

merged 2 commits into from
Mar 16, 2024

Conversation

slhmy
Copy link
Member

@slhmy slhmy commented Mar 10, 2024

We should discuss whether the design is acceptable.

@slhmy slhmy requested review from akamya997 and Zztrans March 10, 2024 02:07
Copy link
Member

@Zztrans Zztrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In current judger, if a previous testdata fail, it will still run next test.

So the struct is fine, the len can be abtain by []TestPoints.

The judger may be expected to not run next data if fail previously?

Maybe a total testdata len is needed?

@slhmy
Copy link
Member Author

slhmy commented Mar 10, 2024

In current judger, if a previous testdata fail, it will still run next test.

So the struct is fine, the len can be abtain by []TestPoints.

The judger may be expected to not run next data if fail previously?

Maybe a total testdata len is needed?

Fair enough, but maybe we should use map for TestPoints? Because idx of each testcase is the filename.

@slhmy slhmy force-pushed the slhmy/judge-result branch from 5687624 to ecfe45d Compare March 10, 2024 08:01
src/service/model/judge.go Outdated Show resolved Hide resolved
@slhmy slhmy force-pushed the slhmy/judge-result branch 2 times, most recently from b4551c5 to 863f263 Compare March 16, 2024 02:59
Copy link
Contributor

@akamya997 akamya997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is enough and we can see how the judger works with memory later.

@akamya997 akamya997 merged commit ffc5a1b into main Mar 16, 2024
2 checks passed
@akamya997 akamya997 deleted the slhmy/judge-result branch March 16, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants