#1761 - [Bug] Dismissing a payment and resending it doesn't clear it as being sent #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebinSong
commented
Oct 18, 2023
| @@ -131,16 +131,16 @@ export default ({ | |||
| ]), | |||
| paymentsList () { | |||
| return this.todoItems.map(item => { | |||
| return item.status === PAYMENT_NOT_RECEIVED // if not received item, re-format the obj | |||
There was a problem hiding this comment.
Turns out it had always been resolved as false here, even when it's actually in the PAYMENT_NOT_RECEIVED'status. So made a correction to this logic as well while working on the task.
taoeffect
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Great work @SebinSong!
Looks like it's working and addressed the issue! 🙂 👍
taoeffect
deleted the
sebin/task/1761-error-regarding-dismissing-payment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1761
Currently
RecordPayment.vuealways creates new payment item regardless of whether it's an existing payment item with the status asPAYMENT_NOT_RECEIVEDor a todo payment that hasn't been payed yet. Apparently this leads to duplicated payment items here and there in the UI. So I made a fix where the component checks if the payment item isPAYMENT_NOT_RECEIVEDor not and then prevents it from creating a new payment item in group state if it is.Hope it sounds good.