#1823 Get the push-notification working again #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebinSong
commented
Feb 1, 2024
| await sbp('service-worker/setup-push-subscription').catch((e) => { | ||
| // TODO: Temporary until this is better addressed. When running tests, | ||
| // it results in an AbortError. |
There was a problem hiding this comment.
Actually, just removing that isNaN(1) made it start working again, and I didn't encounter any AbortError kind of error message while seeing it was running okay. My guess is that probably the similar issue was sorted out a while ago but then that fix didn't get merged to e2e-protocol branch and went to master instead.
Passing run #1844 ↗︎
Details:
Review all test suite changes for PR #1828 ↗︎ |
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1823