#1830 Fix the incorrect route redirection bug #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1849 ↗︎
Details:
Review all test suite changes for PR #1831 ↗︎ |
|||||||||||||||
taoeffect
approved these changes
Feb 4, 2024
Comment on lines
+100
to
+106
| // NOTE: | ||
| // When browser refresh is triggered, there is an issue that Vue router prematurely decides ('loginGuard' there) that | ||
| // the user is not signed in when in actual reality user-login is still being processed and then | ||
| // takes user to 'Home.vue' with the '$route.query.next' being set to the initial url. | ||
| // In this particular condition, the app needs to immediately redirect user to '$route.query.next' | ||
| // so that the user stays in the same page after the browser refresh. | ||
| // (Related GH issue: https://github.com/okTurtles/group-income/issues/1830) |
There was a problem hiding this comment.
This comment is perfect! Thanks for the thorough explanation and the link to the issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1830
I have left this as the comment inside the source-code too but,
This bug happens because Vue-router prematurely decides that the user is not logged in and takes the user to
Home.vuewhile in reality the logging user in(here inmain.js) is still in progress.So as a fix,
navigateToGroupPageinHome.vueneeds a small addition there where it checks if that's what happened.cc. @taoeffect