#1833 - Fix the double dialog box issue on chat file-attachment #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1858 ↗︎
Details:
Review all test suite changes for PR #1834 ↗︎ |
|||||||||||||||
taoeffect
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1833
@Silver-IT
I noticed that the
openFileAttachmethod, which is triggered byfileAttachmentInputElactually somehow programatically clicks itself within the method and that leads to browser unnecessarily showing the file upload dialog twice.I didn't encounter the bug related to drag&drop action you mentioned in the issue though. If you attach some demo of how to exactly reproduce it, will make a fix for that too.
cc. @taoeffect