Implement metadata panel new design #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying opendataeditor with
|
| Latest commit: |
ee536ab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3e897478.opendataeditor.pages.dev |
| Branch Preview URL: | https://664-metadata-pane.opendataeditor.pages.dev |
roll
approved these changes
Dec 16, 2024
@roll in the design it was decided this is the name. I guess @romicolman has checked this already. |
…ditor into 664-metadata-pane
Though it's still a bit flimsy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the redesign of the tabs navigation of the metadata panel. By changing the
MenuTreecomponent toMuiTabsthe complexity of the code is reduced. Some very small details are missing but still can be reviewed.TODO:
Very small details: change color of trash can icon (delete) in ListItems (Contributors, Fields, Licenses, Foreign Keys) and change border color for newly added items. Will create another PR for this.