Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'packages' from app since they wont be used for now #688

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

guergana
Copy link
Collaborator

@guergana guergana commented Dec 11, 2024

Removing references to data type package since this is unused code now.

Since package is a word commonly used for other means, I am not sure if is referring to the same thing and if i should remove the references also here:

Copy link

cloudflare-workers-and-pages bot commented Dec 11, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 06d1d24
Status: ✅  Deploy successful!
Preview URL: https://97da9f35.opendataeditor.pages.dev
Branch Preview URL: https://remove-packages.opendataeditor.pages.dev

View logs

@guergana guergana requested a review from roll December 11, 2024 21:57
Copy link
Collaborator

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good

client/components/Application/Content.tsx Outdated Show resolved Hide resolved
@guergana guergana merged commit c365015 into main Dec 15, 2024
9 checks passed
@guergana guergana deleted the remove-packages branch December 15, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants