-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
664 metadata panel leftovers #701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! The trash icon works ok, but there is something missing in the implementation: it is not possible to add multiple licenses, like it should. This is a video explaining how it should work:
Grabacion.de.pantalla.2024-12-23.a.la.s.9.50.29.a.m.mov
Here is what I see in the improved version:
Grabacion.de.pantalla.2024-12-23.a.la.s.9.57.10.a.m.mov
Hi @romicolman the specific ticket for licenses explicitly said only one license can be added at a time. I think I asked also this in the chat. In the ticket please check where it says "what's new" in the ticket description. If there have been changes since this ticket was created please let me know. |
Sorry for this. Yes, you are right. Please, merge this and I'll create a new ticket to implement multiple licenses. I have double check it and we need to keep it as it was in the original version. |
Deploying opendataeditor with Cloudflare Pages
|
5045507
to
703305a
Compare
This PR deals exclusively with the styling of the trash icon both in the context menu and in list items and the animation added to a list item when first added.