Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

664 metadata panel leftovers #701

Merged
merged 4 commits into from
Dec 24, 2024
Merged

664 metadata panel leftovers #701

merged 4 commits into from
Dec 24, 2024

Conversation

guergana
Copy link
Collaborator

@guergana guergana commented Dec 22, 2024

This PR deals exclusively with the styling of the trash icon both in the context menu and in list items and the animation added to a list item when first added.

@guergana guergana requested review from roll and romicolman December 22, 2024 23:44
Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! The trash icon works ok, but there is something missing in the implementation: it is not possible to add multiple licenses, like it should. This is a video explaining how it should work:

Grabacion.de.pantalla.2024-12-23.a.la.s.9.50.29.a.m.mov

Here is what I see in the improved version:

Grabacion.de.pantalla.2024-12-23.a.la.s.9.57.10.a.m.mov

@guergana
Copy link
Collaborator Author

guergana commented Dec 23, 2024

Hi! The trash icon works ok, but there is something missing in the implementation: it is not possible to add multiple licenses, like it should. This is a video explaining how it should work:

Grabacion.de.pantalla.2024-12-23.a.la.s.9.50.29.a.m.mov

Here is what I see in the improved version:

Grabacion.de.pantalla.2024-12-23.a.la.s.9.57.10.a.m.mov

Hi @romicolman the specific ticket for licenses explicitly said only one license can be added at a time. I think I asked also this in the chat.

#663

In the ticket please check where it says "what's new" in the ticket description. If there have been changes since this ticket was created please let me know.

@romicolman
Copy link
Collaborator

Sorry for this. Yes, you are right. Please, merge this and I'll create a new ticket to implement multiple licenses. I have double check it and we need to keep it as it was in the original version.

Copy link

cloudflare-workers-and-pages bot commented Dec 23, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 893a36d
Status: ✅  Deploy successful!
Preview URL: https://4fd845ae.opendataeditor.pages.dev
Branch Preview URL: https://664-metadata-panel-leftovers.opendataeditor.pages.dev

View logs

@guergana guergana force-pushed the 664-metadata-panel-leftovers branch from 5045507 to 703305a Compare December 23, 2024 19:35
@guergana guergana requested a review from romicolman December 23, 2024 19:36
@guergana guergana merged commit f3453aa into main Dec 24, 2024
4 of 7 checks passed
@guergana guergana deleted the 664-metadata-panel-leftovers branch December 24, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The New Metadata panel design
3 participants