Skip caching failed dumps of http responses

[andrejgou]

Errors when dumping the response are ignored so an empty value is cached, which causes deserialization of the response to fail with an error, which is also ignored, which causes a nil pointer panic.

Summary

Okta HTTP requests were occasionally failing with nil pointer panics. The stack trace showed the panic originating from this line:

okta-sdk-golang/okta/requestExecutor.go

Line 668 in 758b8c3

ct := resp.Header.Get("Content-Type")

called from this line:

okta-sdk-golang/okta/requestExecutor.go

Line 470 in 1d378b9

return buildResponse(resp, re, &v)

The only way the HTTP response can be nil is if deserialization fails, which can only fail if the cached value is invalid, which can only happen if serialization of the HTTP response fails when setting the value in the cache:

okta-sdk-golang/okta/cache/goCache.go

Line 59 in 758b8c3

cacheableResponse, _ := httputil.DumpResponse(value, true)

The easiest fix I could think of was to just skip setting the cache for values that failed serialization. The only potential impact is additional cache misses, but only for invalid values that aren't usable anyway.

Fixes N/A

Type of PR

• Bug Fix (non-breaking fixes to existing functionality)
• New Feature (non-breaking changes that add new functionality)
• Documentation update
• Test Updates
• Other (Please describe the type)

Test Information

• My PR required test updates

Go Version:
Os Version:
OpenAPI Spec Version:

Signoff

• I have submitted a CLA for this PR
• Each commit message explains what the commit does
• I have updated documentation to explain what my PR does
• My code is covered by tests if required
• I ran make fmt on my code
• I did not edit any automatically generated files

[github-actions]

This PR has been marked stale because there has been no activity within the last 28 days. To keep this PR active, remove the stale label.

[github-actions]

This PR has been marked stale because there has been no activity within the last 28 days. To keep this PR active, remove the stale label.