Skip to content

Commit

Permalink
disable convenience symlinks in examples (#21)
Browse files Browse the repository at this point in the history
Prevent convenience symlinks from being generated - they can cause
cycles that crash Bazel:

ERROR: Cycle detected but could not be properly displayed due to an internal problem. Please file an issue. Raw display: topLevelKey: BuildDriverKey of ActionLookupKey: ConfiguredTargetKey{label=//:apply-fixes.verify, config=BuildConfigurationKey[b357dd09923b37f48f631ab81341a90e6b4443fce0a2dddfde9d204ca537a54e]}
alreadyReported: false
path to cycle:
BuildDriverKey of ActionLookupKey: ConfiguredTargetKey{label=//:apply-fixes.verify, config=BuildConfigurationKey[b357dd09923b37f48f631ab81341a90e6b4443fce0a2dddfde9d204ca537a54e]}
ConfiguredTargetKey{label=//:apply-fixes.verify, config=BuildConfigurationKey[b357dd09923b37f48f631ab81341a90e6b4443fce0a2dddfde9d204ca537a54e]}
ConfiguredTargetKey{label=//:apply-fixes.verify, config=BuildConfigurationKey[5c864536bb2c4dd7b84e076a6dab8f700df816ad8f8998bb302a45cc805cb966]}
ConfiguredTargetKey{label=@@local_clang_tidy_workspace_status//:status, config=BuildConfigurationKey[5c864536bb2c4dd7b84e076a6dab8f700df816ad8f8998bb302a45cc805cb966]}
...

Change-Id: Ieb3098c28157313400d5be807ae47679800fbef8
  • Loading branch information
oliverlee authored Aug 25, 2024
1 parent 200ec7f commit 5eea680
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
3 changes: 3 additions & 0 deletions example/dep-cc_test/.bazelrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
common --enable_bzlmod=false

# older Bazel versions may not support --experimental_convenience_symlinks
build --symlink_prefix=/

build:clang-tidy --aspects=@rules_clang_tidy//:aspects.bzl%check
build:clang-tidy --output_groups=report

Expand Down
5 changes: 4 additions & 1 deletion example/hermetic-toolchain/.bazelrc
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
common --enable_bzlmod=false

# older Bazel versions may not support --experimental_convenience_symlinks
build --symlink_prefix=/

build:clang-tidy --aspects=@rules_clang_tidy//:aspects.bzl%check
build:clang-tidy --output_groups=report

build:clang-tidy-export-fixes --aspects=@rules_clang_tidy//:aspects.bzl%export_fixes
build:clang-tidy-export-fixes --output_groups=report

build --@rules_clang_tidy//:clang-tidy=@llvm_toolchain//:clang-tidy
build --@rules_clang_tidy//:clang-apply-replacements=@llvm_toolchain//:clang-apply-replacements
build --@rules_clang_tidy//:clang-apply-replacements=@llvm_toolchain//:clang-apply-replacements
3 changes: 3 additions & 0 deletions example/misc-unused/.bazelrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
common --enable_bzlmod=false

# older Bazel versions may not support --experimental_convenience_symlinks
build --symlink_prefix=/

build:clang-tidy --aspects=@rules_clang_tidy//:aspects.bzl%check
build:clang-tidy --output_groups=report

Expand Down
3 changes: 3 additions & 0 deletions example/shared-source/.bazelrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
common --enable_bzlmod=false

# older Bazel versions may not support --experimental_convenience_symlinks
build --symlink_prefix=/

build:clang-tidy --aspects=@rules_clang_tidy//:aspects.bzl%check
build:clang-tidy --output_groups=report

Expand Down

0 comments on commit 5eea680

Please sign in to comment.