always generate fixes in ClangTidy aspect #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
Ieb3098c28157313400d5be807ae47679800fbef8
to
main
August 25, 2024 15:35
Always generate the exported fixes when executing a ClangTidy aspect. By using the `check` aspect in the `apply_fixes` rule, this rule can use fixes stored in the action cache if available. As `apply_fixes` now uses the `check` aspect, this commit removes the `export_fixes` aspect as it is no longer used. `--remote_download_toplevel` is suggested as an option in `.bazelrc` so that aspect outputs may be downloaded from a remote cache if present. This is primarily for use with the `apply-fixes` script which does not define fixes as inputs. Change-Id: I3c277a9bad789229b4138d7993d0a609fff0925d
pr-update
bot
force-pushed
the
I3c277a9bad789229b4138d7993d0a609fff0925d
branch
from
01dd1ed to
0fd41a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always generate the exported fixes when executing a ClangTidy aspect. By
using the
checkaspect in theapply_fixesrule, this rule can usefixes stored in the action cache if available.
As
apply_fixesnow uses thecheckaspect, this commit removes theexport_fixesaspect as it is no longer used.--remote_download_toplevelis suggested as an option in.bazelrcsothat aspect outputs may be downloaded from a remote cache if present.
This is primarily for use with the
apply-fixesscript which does notdefine fixes as inputs.
Change-Id: I3c277a9bad789229b4138d7993d0a609fff0925d