Fix comparison bug in case of NULL values

See michaelsogos/pg-diff#45
olivierdalang · Nov 8, 2021 · 825cba2 · 825cba2
1 parent 74ba95c
commit 825cba2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/api/CompareApi.js b/src/api/CompareApi.js
@@ -1458,15 +1458,15 @@ class CompareApi {
 	}
 
 	/**
-	 *
+	 * Returns true if there is a difference between source and target vlue
 	 * @param {Object} sourceValue
 	 * @param {Object} targetValue
 	 */
 	static compareFieldValues(sourceValue, targetValue) {
 		var sourceValueType = typeof sourceValue;
 		var targetValueType = typeof targetValue;
 
-		if (sourceValueType != targetValueType) return false;
+		if (sourceValueType != targetValueType) return true;
 		else if (sourceValue instanceof Date) return sourceValue.getTime() !== targetValue.getTime();
 		else if (sourceValue instanceof Object) return !deepEqual(sourceValue, targetValue);
 		else return sourceValue !== targetValue;