Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OME ontologies: schemas and samples reorganization #93

Closed
wants to merge 2 commits into from

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Dec 9, 2018

Implements the first part of the proposal described in #89

  • specification/samples are migrated under specification/src/main/resources/samples and should be packaged as part of the specification JAR
  • the XSD schemas underspecification/src/main/resources/relased-schemas are renamed as specification/src/main/resources/relased-schemas
  • the corresponding references across the repository (publication script, Cmake files) are adjusted to consume the new paths

With these changes, it should be possible to create specification/src/main/resources/ontologies and add additional samples to specification/src/main/resources/samples.

/cc @joshmoore @norikoba

@sbesson sbesson added the exclude label Dec 9, 2018
@sbesson sbesson changed the title Schemas reorganization for OME ontologies: schemas and samples reorganization Dec 9, 2018
@sbesson
Copy link
Member Author

sbesson commented Jan 15, 2019

After second thought, closing this PR.

Although I still believe we want to fix the name eventually, renaming the released-schemas/ directory might just put unnecessary last minute changes while we try to review and freeze the various components for Bio-Formats 6. More importantly, it does not preclude the addition of the 2016-06 ontology as another top-level directory.

Similarly, packaging the samples as part of the JAR (3977bc7) is hopefully valuable but it should be good to drive this feature using a concrete use case.

@sbesson sbesson closed this Jan 15, 2019
@sbesson sbesson deleted the owl_part_1 branch February 21, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant