-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user: allow setting default group #199
base: master
Are you sure you want to change the base?
Conversation
migrate code from openmicroscopy and fix flake8 see: ome/openmicroscopy@8442eed
Some thoughts of mine from: ome/openmicroscopy#5914 (comment) I don't know if I will have time to make a commit today but on top of this I would imagine the following:
|
Reopening with pytest fix |
Clearly (as mentioned) it would be useful to set the default group to a group that the user is already a member of. This would allow a regular user to set their own default group, without having to be an Admin, which is required by |
👍 also happy to take PRs and/or suggestions on which of the API improvements to use. |
Looking for PRs that could go in a release soon. I this "done" for now? |
Tests are missing and there's no final word on what we want the API to be. Feel free to go ahead without it. |
migrate code from openmicroscopy and fix flake8
see: ome/openmicroscopy@8442eed
https://forum.image.sc/t/set-user-default-group-from-command-line/35171
Adding a parameter to set a user's default group when joining a new group, and a helper function to set the default group for a user.
Ideally the CLI should also allow an ad-hoc "set group" command on it's own, but I see this as an incremental improvement towards that goal, and it certainly answers the use case I have for adding users to a group and setting that to be the default group in one command.
What this PR does
Allows a CLI user to set the default group of a user when adding the user to a group.
Testing this PR
Apply the diff in this PR.
Identify a group which your test user does not belong to.
Issue a CLI command with the new
--as-default
flag like so, with 103 as an example:Then issue a further
Output like the following should appear, if the user was not already a member of the group.
Then
Related reading
Link to cards, tickets, other PRs: https://trello.com/c/sjEk7VQG/487-cli-manage-group-and-user-missing-features
background for understanding this PR
what this PR assists, fixes, or otherwise affects
The missing ability to set the default group of a user by the CLI.