Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createImageFromNumpySeq handles big images #276

Closed
wants to merge 3 commits into from

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Jan 27, 2021

This adds support for big images to conn.createImageFromNumpySeq().

Previously this failed if the numpy planes were larger than 3k * 3k.

Fixes ome/omero-figure#403

I was hoping that this method would "just work" exactly the same with big images and small images, so you didn't have to worry about whether you were creating a big image or not.
Unfortunately, the TileLoop for populating big images with setTile() wants to consume planes in the order:

for t in range(size_t):
    for c in range(size_c):
       for z in range(size_z):
           ...

so the planeGenerator passed to ``conn.createImageFromNumpySeq()` needs to provide planes in that order.
But for small images, we need:

for z in range(size_z):
    for c in range(size_c):
       for t in range(size_t):
           ...

Obviously this is not ideal. But I couldn't think of any way to populate Big Images with the order of planes that is already required by conn.createImageFromNumpySeq().

NB: the OMERO.figure issue above is still fixed, since we only have a single Z and T :)

@will-moore
Copy link
Member Author

Closing since this isn't ready and it's now conflicting with #290 (comment)

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/how-to-get-large-image-arrays-in-a-omero-script/70085/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export to OMERO big image
2 participants