createImageFromNumpySeq handles big images #276
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for big images to
conn.createImageFromNumpySeq()
.Previously this failed if the numpy planes were larger than 3k * 3k.
Fixes ome/omero-figure#403
I was hoping that this method would "just work" exactly the same with big images and small images, so you didn't have to worry about whether you were creating a big image or not.
Unfortunately, the
TileLoop
for populating big images withsetTile()
wants to consume planes in the order:so the
planeGenerator
passed to ``conn.createImageFromNumpySeq()` needs to provide planes in that order.But for small images, we need:
Obviously this is not ideal. But I couldn't think of any way to populate Big Images with the order of planes that is already required by
conn.createImageFromNumpySeq()
.NB: the OMERO.figure issue above is still fixed, since we only have a single Z and T :)