-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add JuliaLang #32
Open
miguelraz
wants to merge
6
commits into
omegaup:main
Choose a base branch
from
miguelraz:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add JuliaLang #32
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6c20ac0
add julia binary to Dockerfile.rootfs
miguelraz 99f6844
add JULIA_ROOT to mkroot
miguelraz 4784c9c
add julia smoketest
miguelraz 8207e50
add julia enum to args.rs
miguelraz 9a8b1b1
add julia match arm to options.rs
miguelraz 0210753
add missing Julia match arm
miguelraz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
print(sum(parse.(Int, split(readline(), ' ')))) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,6 +41,7 @@ _LANGUAGES = [ | |
'kj', | ||
'kp', | ||
'cs', | ||
'jl', | ||
] | ||
_EXTENSIONS = { | ||
'c11-gcc': 'c', | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ use crate::args; | |
const DEFAULT_EXTRA_MEMORY_SIZE_IN_BYTES: u64 = 16 * 1024 * 1024; | ||
const RUBY_EXTRA_MEMORY_SIZE_IN_BYTES: u64 = 56 * 1024 * 1024; | ||
const GO_EXTRA_MEMORY_SIZE_IN_BYTES: u64 = 512 * 1024 * 1024; | ||
const JULIA_EXTRA_MEMORY_SIZE_IN_BYTES: u64 = 512 * 1024 * 1024; | ||
|
||
// These are obtained by running an "empty" and measuring | ||
// its memory consumption, as reported by omegajail. | ||
|
@@ -686,6 +687,21 @@ impl JailOptions { | |
seccomp_profile_name = String::from("go"); | ||
execve_args.extend([format!("./{}", args.run_target)]); | ||
} | ||
args::Language::Julia => { | ||
extra_memory_size_in_bytes = JULIA_EXTRA_MEMORY_SIZE_IN_BYTES; | ||
seccomp_profile_name = String::from("jl"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems like the seccomp files are missing from this change! can they be added? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure - I don't know what those are though 😅 |
||
mounts.push(MountArgs { | ||
source: Some(root.join("root-julia")), | ||
target: rootfs.join("opt/julia"), | ||
fstype: None, | ||
flags: MsFlags::MS_BIND | MsFlags::MS_RDONLY, | ||
data: None, | ||
}); | ||
execve_args.extend([ | ||
String::from("/usr/bin/julia"), | ||
format!("{}.jl", args.run_target), | ||
]); | ||
} | ||
args::Language::JavaScript => { | ||
seccomp_profile_name = String::from("js"); | ||
mounts.push(MountArgs { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how was this measured?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just took the largest I saw.
I'm guessing it will need tweaking.