Custom binary sensor #162
Custom binary sensor #162
Conversation
There was a problem hiding this comment.
@atanasenko @lanwin interested on what you think the best way to handle the different custom sensor types is? If you think this way is ok I could create as enum, but any better ideas?
There was a problem hiding this comment.
Yes. In main I removed the custom parameter compleatly and just call set_custom_sensor every time. If there is no custom sensor, this does nothing.
So the best would be if you do the same.
| return optional<std::set<uint16_t>>(); | ||
| } | ||
|
|
||
| void /*MessageTarget::*/ set_custom_binary_sensor(const std::string address, uint16_t message_number, bool value) override |
There was a problem hiding this comment.
Can you please check the indentation here.
There was a problem hiding this comment.
Yes. In main I removed the custom parameter compleatly and just call set_custom_sensor every time. If there is no custom sensor, this does nothing.
So the best would be if you do the same.
I've created this to compliment the custom sensors, so we can have binary sensors for some of the heat pump variables.
Needs a bit of a review, its generally fine I think apart from how I am handling the call to process the message, currently with an type (int) variable. If we think that's a good way of doing it, could firm that up with an enum, but interested on if there is a view of a better way?