Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin skin-tone to ^2.0.0 and add renovate.json ignoreDeps #157

Merged

Conversation

JoshuaKGoldberg
Copy link
Collaborator

PR Checklist

Overview

Continues #154 by pinning the last ESM-only dependency, skin-tone, to its pre-#142 version. See #153 (comment).

I don't know why the CJS test from #154 passed with skin-tone (exports oddity? race condition?) so manually disables the ESM-only dependencies in renove.json. Which is ... most of them.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac996a3) 100.00% compared to head (dcd6c43) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #157   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          263       263           
  Branches        28        28           
=========================================
  Hits           263       263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3eae526 into omnidan:main Nov 20, 2023
15 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the skin-tone-and-ignore-deps branch November 20, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Add test that CJS require() works (not just ESM import)
1 participant