[HIP] Fix libclang_rt.builtins.a not found #532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the compiler from oneAPI's Base Toolkit and the Codeplay AMD plugin fails to compile by default with the error:
As far as I know this is an issue for all ROC backends. The issue is that the command
find_package(HIP)
invokes${HIP_CXX_COMPILER} -print-libgcc-file-name --rtlib=compiler-rt
to find the path of a dependency whereHIP_CXX_COMPILER
is set asCMAKE_CXX_COMPILER
by default. This command is meant to be run with HIP'sclang++
but whenicpx
is used the command is outputting a non-existant file.As the documentation suggests this can be worked around by building intel/llvm which is not user friendly. The second workaround of setting
LIBRARY_PATH
did not work for me using ROCm 6.1.0 so I am suggesting to remove it.The suggested solution should be more resilient and does not need any more action from the user as the environment variables
HIPROOT
orROCM_PATH
should already be set to use the ROC libraries.Fixes #336
Checklist
All Submissions
Bug fixes
GitHub issue or in this PR)?