-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bit_kmers function will panic at 'attempt to multiply with overflow', if k-mer length is longer than 32 bp. #58
Comments
Hi, We probably are going to revamp the bit kmers we have as we just built a pretty huge project using needletail and ended up re-implementing the bit encoding to be more flexible. |
@Keats I understand and looking forward to re-implementing the bit encoding! Regards, |
You can check kmers bit encoding https://github.com/COMBINE-lab/kmers |
I will have to take a look at that @natir ! |
@natir |
Sure @Keats my message is more for @tetsuro90 than you, maybe kmers match to @tetsuro90 requirement. |
Yeah I understood, I just meant that I ned to look at kmers before doing changes to needletail to see if we can consolidate somehow |
Thank you for great software.
I want to use
bit_kmer
function to count k-mer in fastq file.But, if k-mer length is longer than 32 bases, it will panic.
I think this is because the bit_kmer sequence is represented as a u64 type (
type BitKmerSeq = u64
), but is there a method to perform k-mer counts over 32 bp?I am using HashMap as a database for k-mer counts, but if I use fastq files as input, HashMap becomes too large.
So, I would like to use bit_kmer to reduce it as much as possible. Is there an alternative method that could be considered, such as "use u128 type"?
Regards,
tetsuro90
The text was updated successfully, but these errors were encountered: