Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins: is_dir was always true #679

Merged
merged 1 commit into from
Nov 14, 2023
Merged

plugins: is_dir was always true #679

merged 1 commit into from
Nov 14, 2023

Conversation

vlaci
Copy link
Contributor

@vlaci vlaci commented Nov 14, 2023

No description provided.

@qkaiser qkaiser self-requested a review November 14, 2023 14:36
@qkaiser qkaiser added the bug Something isn't working label Nov 14, 2023
@qkaiser
Copy link
Contributor

qkaiser commented Nov 14, 2023

How did you pick it up ? Ruff ?

@vlaci
Copy link
Contributor Author

vlaci commented Nov 14, 2023

How did you pick it up ? Ruff ?

😄 Experimented with mypy:

unblob/plugins.py:58: error: Function "is_dir" could always be true in boolean context  [truthy-function]

@vlaci vlaci merged commit 861d76b into main Nov 14, 2023
22 of 24 checks passed
@vlaci vlaci deleted the plugin-is-dir branch November 14, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkaiser qkaiser qkaiser approved these changes

Assignees

@vlaci vlaci

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlaci @qkaiser