Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds USDCFlow, README, and transactions, and basic tests #2

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Adds USDCFlow, README, and transactions, and basic tests #2

merged 6 commits into from
Aug 7, 2024

Conversation

joshuahannan
Copy link
Member

@joshuahannan joshuahannan commented Jul 31, 2024 •
edited
Loading

Description

Based on this document

A contract that is a basic Fungible Token contract, but accepts old FiatToken Vaults in order to mint new USDCFlow Vaults. It will be integrated into the Flow VM bridge as the bridged version of EVM USDC after Crescendo.

For contributor use:

  • Targeted PR against master branch
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@joshuahannan joshuahannan changed the title First draft of wrapped fiat token First draft of WrappedFiatToken Jul 31, 2024
sisyphusSmiling
sisyphusSmiling approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core functionality of the wrapping contract lgtm, left a couple smaller comments & suggestions

contracts/WrappedFiatToken.cdc Outdated Show resolved Hide resolved
contracts/WrappedFiatToken.cdc Outdated Show resolved Hide resolved
contracts/WrappedFiatToken.cdc Outdated Show resolved Hide resolved
coverage.json Outdated Show resolved Hide resolved
tests/scripts/get_token_metadata.cdc Outdated Show resolved Hide resolved
contracts/WrappedFiatToken.cdc Outdated Show resolved Hide resolved
This was referenced Aug 1, 2024
Closed
Closed
@joshuahannan joshuahannan changed the title First draft of WrappedFiatToken Adds USDCFlow, README, and transactions, and basic tests Aug 7, 2024
nvdtf
nvdtf approved these changes Aug 7, 2024
View reviewed changes
contracts/USDCFlow.cdc Show resolved Hide resolved
@joshuahannan joshuahannan merged commit c123fe8 into main Aug 7, 2024
2 checks passed
@joshuahannan joshuahannan deleted the wfiatToken branch August 7, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisyphusSmiling sisyphusSmiling sisyphusSmiling approved these changes

@nvdtf nvdtf nvdtf approved these changes

@nialexsan nialexsan nialexsan approved these changes

@gregsantos gregsantos Awaiting requested review from gregsantos

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshuahannan @nialexsan @nvdtf @sisyphusSmiling