-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce String.replaceAll
instance function
#2814
Introduce String.replaceAll
instance function
#2814
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #2814 +/- ##
=======================================================
Coverage 79.84% 79.84%
=======================================================
Files 343 343
Lines 81056 81088 +32
=======================================================
+ Hits 64719 64747 +28
- Misses 14027 14029 +2
- Partials 2310 2312 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
1d880e9
to
401eab8
Compare
Force push to resolve merge conflict. |
@turbolent @dsainati1 Could you please take a look? Thanks! |
@SupunS Should we merge this? Seems a relatively straightforward change. |
Sorry I missed this! The PR looks good, but the function needs to have its computation metered, as it performs a non-constant operation. The same also applies to the other stdlib PRs that got opened so far. This might require "inlining" the replaceAll call to the Go stdlib, and calling I opened #2879 to track this, see the details there. |
Work towards #2813
Description
Adds
str.replaceAll(_ of: String, _ with: String): String
function to Cadence.master
branchFiles changed
in the Github PR explorer