-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batched EVM transaction walkthrough #983
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
### Approve ERC721 Transfer | ||
|
||
Our example `MaybeMintERC721` contract accepts WFLOW in exchange for minting an NFT. However, the contract cannot move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great description of what wrapped Flow is, but why would we need it here instead of just regular, unwrapped Flow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine if it's just to demonstrate the complex chain of transactions, but I'd be explicit as to why.
self.coa.deposit(from: <-fundingVault) | ||
``` | ||
|
||
Taking a look at the full transaction, we can see an explicit check that the COA has enough FLOW to cover the mint cost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have enough Flow and failed before this. Got the error that there wasn't enough in the vault to transfer to.
Tried to repro by switching accounts and even after refreshing, I'm getting: Error
1 error occurred:
* transaction verification failed: [Error Code: 1006] invalid proposal key: public key 0 on account d83e39fd1baa9ac3 does not have a valid signature: [Error Code: 1008] invalid payload signature: public key 0 on account d83e39fd1baa9ac3 does not have a valid signature: signature is not valid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that account only has 0.001
FLOW, try again after funding from faucet. The other invalid signer errors may be wallet issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tutorial! Left some non-blocking feedback.
I really would try to guide people through building and testing the Cadence script step-by-step if you have time. Learning through doing is much more powerful!
Co-authored-by: Brian Doyle <[email protected]>
bb9273b
to
0d4649c
Compare
Related: onflow/batched-evm-exec-example#7
Description