Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embedded flags issue when running Dependency Manager flags manually #1530

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Apr 19, 2024

Closes #1519


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@chasefleming chasefleming added the Bug The issue represents a bug, malfunction, regression label Apr 19, 2024
@chasefleming chasefleming merged commit a42acab into master Apr 22, 2024
5 checks passed
@chasefleming chasefleming deleted the chasefleming/fix-dep-flags branch April 22, 2024 20:34
chasefleming added a commit that referenced this pull request Apr 22, 2024
* Bump codecov/codecov-action from 1 to 4

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 1 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v1...v4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump actions/add-to-project from 0.4.1 to 0.6.1

Bumps [actions/add-to-project](https://github.com/actions/add-to-project) from 0.4.1 to 0.6.1.
- [Release notes](https://github.com/actions/add-to-project/releases)
- [Commits](actions/add-to-project@v0.4.1...v0.6.1)

---
updated-dependencies:
- dependency-name: actions/add-to-project
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update Flow dependencies to latest version (#1509)

* Update to latest Cadence Language Server (#1513)

* Bump google.golang.org/grpc from 1.63.0 to 1.63.2 (#1515)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.63.0 to 1.63.2.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.63.0...v1.63.2)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/add-to-project from 0.6.1 to 1.0.1 (#1514)

Bumps [actions/add-to-project](https://github.com/actions/add-to-project) from 0.6.1 to 1.0.1.
- [Release notes](https://github.com/actions/add-to-project/releases)
- [Commits](actions/add-to-project@v0.6.1...v1.0.1)

---
updated-dependencies:
- dependency-name: actions/add-to-project
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jordan Ribbink <[email protected]>

* Bump version to v1.17.1

* Fix embedded flags issue when running Dependency Manager flags manually (#1530)

* Fix embedded flags issue

* Run lint fix

* Use sconfig

* Run goimport fix

---------

Co-authored-by: Chase Fleming <[email protected]>

* Change flags anme

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jordan Ribbink <[email protected]>
Co-authored-by: Chase Fleming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The issue represents a bug, malfunction, regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded flags work in tests but not manually
2 participants