Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of Core Contract names for flow deps add #1758

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Sep 18, 2024

Closes #1753

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.

Project coverage is 29.75%. Comparing base (ff212fb) to head (1fb224f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/dependencymanager/add.go 0.00% 5 Missing ⚠️
internal/dependencymanager/dependencyinstaller.go 83.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1758      +/-   ##
==========================================
+ Coverage   29.54%   29.75%   +0.20%     
==========================================
  Files          88       88              
  Lines        5154     5176      +22     
==========================================
+ Hits         1523     1540      +17     
- Misses       3444     3449       +5     
  Partials      187      187              
Flag Coverage Δ
unittests 29.75% <68.96%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink merged commit 10ebb57 into master Sep 23, 2024
11 checks passed
@jribbink jribbink deleted the jribbink/core-aliases branch September 23, 2024 19:29
@jribbink jribbink added the Feature A new user feature or a new package API label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aliases for Core Contracts in Dependency Manager
3 participants